xF2 Add-on [DigitalPoint] Better Google Analytics 1.0.10

[joostyle]

Some erros

Error: Class 'XF\Admin\ControllerPlugin\AbstractPlugin' not found in src/addons/DigitalPoint/Analytics/Admin/ControllerPlugin/AnalyticsOAuth.php at line 7

1. include() in src/vendor/composer/ClassLoader.php at line 444
2. Composer\Autoload\includeFile() in src/vendor/composer/ClassLoader.php at line 322
3. Composer\Autoload\ClassLoader->loadClass()
4. spl_autoload_call() in src/XF/Mvc/Controller.php at line 648
5. XF\Mvc\Controller->plugin() in src/addons/DigitalPoint/Analytics/XF/Admin/Controller/Option.php at line 12
6. DigitalPoint\Analytics\XF\Admin\Controller\Option->actionGoogleAnalyticsOAuth() in src/XF/Mvc/Dispatcher.php at line 350
7. XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
8. XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
9. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
10. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2184
11. XF\App->run() in src/XF.php at line 391
12. XF::runApp() in admin.php at line 13

 

[BattleKing]

Some erros

Error: Class 'XF\Admin\ControllerPlugin\AbstractPlugin' not found in src/addons/DigitalPoint/Analytics/Admin/ControllerPlugin/AnalyticsOAuth.php at line 7

1. include() in src/vendor/composer/ClassLoader.php at line 444
2. Composer\Autoload\includeFile() in src/vendor/composer/ClassLoader.php at line 322
3. Composer\Autoload\ClassLoader->loadClass()
4. spl_autoload_call() in src/XF/Mvc/Controller.php at line 648
5. XF\Mvc\Controller->plugin() in src/addons/DigitalPoint/Analytics/XF/Admin/Controller/Option.php at line 12
6. DigitalPoint\Analytics\XF\Admin\Controller\Option->actionGoogleAnalyticsOAuth() in src/XF/Mvc/Dispatcher.php at line 350
7. XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
8. XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
9. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
10. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2184
11. XF\App->run() in src/XF.php at line 391
12. XF::runApp() in admin.php at line 13

joostyleWhich version of Xenforo are you running on?

 

[BattleKing]

For my understanding this is not compatible with XF2.1.x, because here the ControllerPlugin folder and the file AbstractPlugin is missing, or lets say it is in a different location.

When do you get this error message?
Tell me the steps to reproduce it

BattleKingJust found how to replicate it, it seems that it is not compatible in that case. the AbstractPlugin class is in a different location and the content is also a little bit different, If I change the path to that it still failed.

Modifications in AnalyticsOAuth.php
//use XF\Admin\ControllerPlugin\AbstractPlugin;
use \XF\Api\ControllerPlugin\AbstractPlugin;

But then you will get this error

LogicException: API controller plugins only work with API controllers in src\XF\Api\ControllerPlugin\AbstractPlugin.php at line 21

1. XF\Api\ControllerPlugin\AbstractPlugin->__construct() in src\XF\Mvc\Controller.php at line 648
2. XF\Mvc\Controller->plugin() in src\addons\DigitalPoint\Analytics\XF\Admin\Controller\Option.php at line 12
3. DigitalPoint\Analytics\XF\Admin\Controller\Option->actionGoogleAnalyticsOAuth() in src\XF\Mvc\Dispatcher.php at line 350
4. XF\Mvc\Dispatcher->dispatchClass() in src\XF\Mvc\Dispatcher.php at line 257
5. XF\Mvc\Dispatcher->dispatchFromMatch() in src\XF\Mvc\Dispatcher.php at line 113
6. XF\Mvc\Dispatcher->dispatchLoop() in src\XF\Mvc\Dispatcher.php at line 55
7. XF\Mvc\Dispatcher->run() in src\XF\App.php at line 2184
8. XF\App->run() in src\XF.php at line 391
9. XF::runApp() in admin.php at line 13

Reason in \XF\Api\ControllerPlugin\AbstractPlugin.php:
public function __construct(\XF\Mvc\Controller $controller)
{
if (!($controller instanceof \XF\Api\Controller\AbstractController))
{
throw new \LogicException("API controller plugins only work with API controllers");
}

$controller is an instance of \XF\Admin\Controller\AbstractController
Let's wait for a fix of the developer themself

 

[joostyle]

Just found how to replicate it, it seems that it is not compatible in that case. the AbstractPlugin class is in a different location and the content is also a little bit different, If I change the path to that it still failed.

Modifications in AnalyticsOAuth.php
//use XF\Admin\ControllerPlugin\AbstractPlugin;
use \XF\Api\ControllerPlugin\AbstractPlugin;

But then you will get this error

LogicException: API controller plugins only work with API controllers in src\XF\Api\ControllerPlugin\AbstractPlugin.php at line 21

1. XF\Api\ControllerPlugin\AbstractPlugin->__construct() in src\XF\Mvc\Controller.php at line 648
2. XF\Mvc\Controller->plugin() in src\addons\DigitalPoint\Analytics\XF\Admin\Controller\Option.php at line 12
3. DigitalPoint\Analytics\XF\Admin\Controller\Option->actionGoogleAnalyticsOAuth() in src\XF\Mvc\Dispatcher.php at line 350
4. XF\Mvc\Dispatcher->dispatchClass() in src\XF\Mvc\Dispatcher.php at line 257
5. XF\Mvc\Dispatcher->dispatchFromMatch() in src\XF\Mvc\Dispatcher.php at line 113
6. XF\Mvc\Dispatcher->dispatchLoop() in src\XF\Mvc\Dispatcher.php at line 55
7. XF\Mvc\Dispatcher->run() in src\XF\App.php at line 2184
8. XF\App->run() in src\XF.php at line 391
9. XF::runApp() in admin.php at line 13

Reason in \XF\Api\ControllerPlugin\AbstractPlugin.php:
public function __construct(\XF\Mvc\Controller $controller)
{
if (!($controller instanceof \XF\Api\Controller\AbstractController))
{
throw new \LogicException("API controller plugins only work with API controllers");
}

$controller is an instance of \XF\Admin\Controller\AbstractController
Let's wait for a fix of the developer themself

BattleKingI assume that the description of the extension states : Compatible XF Versions 2.1, 2.2
The error occurred after installation - this went fine and subsequent attempts to connect to a Google account

Description of the solution, can it be verified? Thank you : https://xenforo.com/community/threads/digitalpoint-better-google-analytics.206200/page-13#post-1580096

 

[BattleKing]

I assume that the description of the extension states : Compatible XF Versions 2.1, 2.2
The error occurred after installation - this went fine and subsequent attempts to connect to a Google account

Description of the solution, can it be verified? Thank you : https://xenforo.com/community/threads/digitalpoint-better-google-analytics.206200/page-13#post-1580096

joostyleSolved and updated

 

[joostyle]

Solved and updated

BattleKingIt works Well done Thank you

 

[SNap!]

SNap! updated [DigitalPoint] Better Google Analytics with a new update entry:

Overview Updates (9) Reviews (4) History Discussion Leave a rating Watch Add bookmark New dimensio

• Added geographic dimensions (city, region, country) as options for charts.
• Added "Signed in user" as an available dimension for charts.
• Give a better error message about Organic Google search dimensions requiring an association to the respective Google Search Console property (including link to make that association).

Read the rest of this update entry...

 

[SNap!]

SNap! updated [DigitalPoint] Better Google Analytics with a new update entry:

Compatibility fix for XF 2.0 and 2.1

• Removed usage of abstract class that required XF 2.2.0+ to exist.

Read the rest of this update entry...

 

[joostyle]

In Error Log :

Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown

• ErrorException: Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown . src/XF/Template/Templater.php:591

Stack trace​

#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Macro admin:ana...', '/data/0/b/0b4e9...', 591, Array)
#1 src/XF/Template/Templater.php(591): trigger_error('Macro admin:ana...', 512)
#2 src/XF/Template/Templater.php(705): XF\Template\Templater->getTemplateMacro('admin', 'analytics_repor...', 'filter_macros::...')
#3 internal_data/code_cache/templates/l1/s0/admin/analytics_report_chart.php(66): XF\Template\Templater->callMacro('analytics_repor...', 'filter_macros::...', Array, Array)
#4 src/XF/Template/Templater.php(1320): XF\Template\Templater->{closure}(Object(SV\StandardLib\XF\Template\Templater), Array)
#5 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('analytics_repor...', Array)
#6 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#7 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Html->renderView('DigitalPoint\\An...', 'admin:analytics...', Array)
#8 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#11 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#12 src/XF.php(391): XF\App->run()
#13 admin.php(13): XF::runApp('XF\\Admin\\App')
#14 {main}

Request state​

array(4) {
["url"] => string(68) "/admin.php?analytics/charts&uri=https%3A%2F%2Fforum.elektrolab.eu%2F"
["referrer"] => string(28) "https://forum.elektrolab.eu/"
["_GET"] => array(2) {
["analytics/charts"] => string(0) ""
["uri"] => string(28) "https://forum.elektrolab.eu/"
}
["_POST"] => array(0) {
}
}

 

[BattleKing]

Please tell how to reproduce.
Please check as well, if the template is available:

ACP>Appearance>Styles>Master style - Templates>Edit template: analytics_report_chart

 

[joostyle]

Please tell how to reproduce.
Please check as well, if the template is available:

ACP>Appearance>Styles>Master style - Templates>Edit template: analytics_report_chart

BattleKinganalytics_report_chart I did not find

 

[BattleKing]

analytics_report_chart I did not find

joostyleIt is under admin

 

[joostyle]

It is under admin

BattleKingIt is clear to me that in administration, yet this error does not occur permanently. Today, for example, I did not have it. Today there appeared this :

ErrorException: Job DBTech\Mail: DigestEmail: [E_WARNING] Declaration of DigitalPoint\Analytics\XF\Mail\Mailer::send(Swift_Mime_SimpleMessage $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true) should be compatible with XF\Mail\Mailer::send(Swift_Mime_Message $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true)
src/addons/DigitalPoint/Analytics/XF/Mail/Mailer.php:0

Stack trace​

#0 src/vendor/composer/ClassLoader.php(444): XF::handlePhpError(2, '[E_WARNING] Dec...', '/data/0/b/0b4e9...', 0, Array)
#1 src/vendor/composer/ClassLoader.php(444): include()
#2 src/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/data/0/b/0b4e9...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('DigitalPoint\\An...')
#4 [internal function]: spl_autoload_call('DigitalPoint\\An...')
#5 src/XF/Extension.php(172): class_exists('DigitalPoint\\An...')
#6 src/XF/App.php(2668): XF\Extension->extendClass('XF\\Mail\\Mailer', NULL)
#7 src/XF/App.php(943): XF\App->extendClass('XF\\Mail\\Mailer')
#8 src/XF/Container.php(28): XF\App->XF\{closure}(Object(XF\Container))
#9 src/XF/App.php(2400): XF\Container->offsetGet('mailer')
#10 src/addons/DBTech/Mail/Job/DigestEmail.php(188): XF\App->mailer()
#11 src/XF/Job/AbstractUserCriteriaJob.php(59): DBTech\Mail\Job\DigestEmail->executeAction(Object(SV\AdvancedBbCodesPack\XF\Entity\User))
#12 src/addons/DBTech/Mail/Job/DigestEmail.php(92): XF\Job\AbstractUserCriteriaJob->run(G)
#13 src/XF/Job/Manager.php(253): DBTech\Mail\Job\DigestEmail->run(G)
#14 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#15 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#16 job.php(42): XF\Job\Manager->runQueue(false, 8)
#17 {main}

Request state​

array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(37) "https://forum.elektrolab.eu/admin.php"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

 

[joostyle]

It is under admin

BattleKingor second error
ErrorException: Job DBTech\Mail: DigestEmail: [E_WARNING] Declaration of DigitalPoint\Analytics\XF\Mail\Mailer::send(Swift_Mime_SimpleMessage $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true) should be compatible with XF\Mail\Mailer::send(Swift_Mime_Message $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true)src/addons/DigitalPoint/Analytics/XF/Mail/Mailer.php:0

Stack trace​

#0 src/vendor/composer/ClassLoader.php(444): XF::handlePhpError(2, '[E_WARNING] Dec...', '/data/0/b/0b4e9...', 0, Array)
#1 src/vendor/composer/ClassLoader.php(444): include()
#2 src/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/data/0/b/0b4e9...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('DigitalPoint\\An...')
#4 [internal function]: spl_autoload_call('DigitalPoint\\An...')
#5 src/XF/Extension.php(172): class_exists('DigitalPoint\\An...')
#6 src/XF/App.php(2668): XF\Extension->extendClass('XF\\Mail\\Mailer', NULL)
#7 src/XF/App.php(943): XF\App->extendClass('XF\\Mail\\Mailer')
#8 src/XF/Container.php(28): XF\App->XF\{closure}(Object(XF\Container))
#9 src/XF/App.php(2400): XF\Container->offsetGet('mailer')
#10 src/addons/DBTech/Mail/Job/DigestEmail.php(188): XF\App->mailer()
#11 src/XF/Job/AbstractUserCriteriaJob.php(59): DBTech\Mail\Job\DigestEmail->executeAction(Object(SV\AdvancedBbCodesPack\XF\Entity\User))
#12 src/addons/DBTech/Mail/Job/DigestEmail.php(92): XF\Job\AbstractUserCriteriaJob->run(G)
#13 src/XF/Job/Manager.php(253): DBTech\Mail\Job\DigestEmail->run(G)
#14 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#15 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#16 job.php(42): XF\Job\Manager->runQueue(false, 8)
#17 {main}

Request state​

array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(48) "https://forum.elektrolab.eu/find-threads/started"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

 

[BattleKing]

or second error
ErrorException: Job DBTech\Mail: DigestEmail: [E_WARNING] Declaration of DigitalPoint\Analytics\XF\Mail\Mailer::send(Swift_Mime_SimpleMessage $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true) should be compatible with XF\Mail\Mailer::send(Swift_Mime_Message $message, ?Swift_Transport $transport = NULL, ?array $queueEntry = NULL, $allowRetry = true)src/addons/DigitalPoint/Analytics/XF/Mail/Mailer.php:0

Stack trace​

#0 src/vendor/composer/ClassLoader.php(444): XF::handlePhpError(2, '[E_WARNING] Dec...', '/data/0/b/0b4e9...', 0, Array)
#1 src/vendor/composer/ClassLoader.php(444): include()
#2 src/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/data/0/b/0b4e9...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('DigitalPoint\\An...')
#4 [internal function]: spl_autoload_call('DigitalPoint\\An...')
#5 src/XF/Extension.php(172): class_exists('DigitalPoint\\An...')
#6 src/XF/App.php(2668): XF\Extension->extendClass('XF\\Mail\\Mailer', NULL)
#7 src/XF/App.php(943): XF\App->extendClass('XF\\Mail\\Mailer')
#8 src/XF/Container.php(28): XF\App->XF\{closure}(Object(XF\Container))
#9 src/XF/App.php(2400): XF\Container->offsetGet('mailer')
#10 src/addons/DBTech/Mail/Job/DigestEmail.php(188): XF\App->mailer()
#11 src/XF/Job/AbstractUserCriteriaJob.php(59): DBTech\Mail\Job\DigestEmail->executeAction(Object(SV\AdvancedBbCodesPack\XF\Entity\User))
#12 src/addons/DBTech/Mail/Job/DigestEmail.php(92): XF\Job\AbstractUserCriteriaJob->run(G)
#13 src/XF/Job/Manager.php(253): DBTech\Mail\Job\DigestEmail->run(G)
#14 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#15 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#16 job.php(42): XF\Job\Manager->runQueue(false, 8)
#17 {main}

Request state​

array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(48) "https://forum.elektrolab.eu/find-threads/started"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

joostyleSounds like you are using DBTech Mail ... addon as well, is that right?
Looks like the error is raised by that addon.


But how you were able to reproduce the first error with the macro is missing?

 

[joostyle]

Sounds like you are using DBTech Mail ... addon as well, is that right?
Looks like the error is raised by that addon.


But how you were able to reproduce the first error with the macro is missing?

BattleKingI've disabled the DBTech Mail add-on for now and I'll keep an eye on the error log to see if anything shows up. When it's running smoothly, I'll try to uninstall it (hopefully it won't crash the system)

"But how you were able to reproduce the first error with the macro is missing?"

I have absolutely no idea, I just looked in the error log and it was there, it was probably a bug in the DBTech Mail plugin

 

[BattleKing]

I've disabled the DBTech Mail add-on for now and I'll keep an eye on the error log to see if anything shows up. When it's running smoothly, I'll try to uninstall it (hopefully it won't crash the system)

"But how you were able to reproduce the first error with the macro is missing?"

I have absolutely no idea, I just looked in the error log and it was there, it was probably a bug in the DBTech Mail plugin

joostyleI mean this error:
Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown

• ErrorException: Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown . src/XF/Template/Templater.php:591

​

 

[joostyle]

I mean this error:
Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown

• ErrorException: Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown . src/XF/Template/Templater.php:591

​

BattleKingFor example, now, after clicking from the home screen on the chart view icon in the administration and changing the displayed parameters

 

[BattleKing]

It is under admin

BattleKingdid you find the template I mentioned under admin?
I cannot reproduce the problem, sorry.

If the template is there try to rebuild the cache

 

[joostyle]

ErrorException: Template error: Macro admin:analytics_report_chart:filter_macros::filter_bar is unknown src/XF/Template/Templater.php:591

The bug has manifested itself again

 

[SNap!]

SNap! updated [DigitalPoint] Better Google Analytics with a new update entry:

Ability to not use Google Analytics with certain user group(s)

New user group permission: Do not track with Google Analytics

Read the rest of this update entry...

 

[SNap!]

SNap! updated [DigitalPoint] Better Google Analytics with a new update entry:

Fix for email tracking and a few other minor things

• Fixed issue where an old installation of legacy (XF1) version of add-on would cause installation issues of this (XF2) version of add-on.
• Fixed issue where some email sent/email read events wouldn't get logged if you are tracking events by user ID.
• Added missing phrases for "city" and "region".
• Added ability to debug events going through backend measurement protocol.
• Using new Google Analytics Admin API endpoint (going from v1alpha to v1beta).

Read the rest of this update entry...