Fatal Error: Declaration of Brivium\AdvancedThreadRating

MEGAHERZ

MEGAHERZ

Collaborate
Collaborate
Registered
Joined
Mar 16, 2019
Messages
50
Points
38

Reputation:

keep getting error logs about brivium advanced thread rating 2.2.0 would appreciate some help on fixing this.

Code: 
Server error log
ErrorException: Fatal Error: Declaration of Brivium\AdvancedThreadRating\FindNew\RatingItem::filterResults(XF\Mvc\Entity\ArrayCollection $results) must be compatible with XF\FindNew\AbstractHandler::filterResults(XF\Mvc\Entity\AbstractCollection $results) src/addons/Brivium/AdvancedThreadRating/FindNew/RatingItem.php:84
Generated by: Unknown account Sep 24, 2023 at 2:43 PM
Stack trace
#0 [internal function]: XF::handleFatalError()
#1 {main}
Request state
array(4) {
  ["url"] => string(26) "/whats-new/thread-ratings/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
 
BattleKing

BattleKing

Spirit of darkness
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P Member
Collaborate
Registered
Joined
May 24, 2020
Messages
3,520
Points
523

Reputation:

MEGAHERZ said:
keep getting error logs about brivium advanced thread rating 2.2.0 would appreciate some help on fixing this.

Code: 
Server error log
ErrorException: Fatal Error: Declaration of Brivium\AdvancedThreadRating\FindNew\RatingItem::filterResults(XF\Mvc\Entity\ArrayCollection $results) must be compatible with XF\FindNew\AbstractHandler::filterResults(XF\Mvc\Entity\AbstractCollection $results) src/addons/Brivium/AdvancedThreadRating/FindNew/RatingItem.php:84
Generated by: Unknown account Sep 24, 2023 at 2:43 PM
Stack trace
#0 [internal function]: XF::handleFatalError()
#1 {main}
Request state
array(4) {
  ["url"] => string(26) "/whats-new/thread-ratings/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
Click to expand...
MEGAHERZtry to change in file "src\addons\Brivium\AdvancedThreadRating\FindNew\RatingItem.php" the following function from
PHP: 
    protected function filterResults(\XF\Mvc\Entity\ArrayCollection $results)
    {
        $visitor = \XF::visitor();

        return $results->filter(function(Rating $rating) use($visitor)
        {
            return ($rating->canView() && !$visitor->isIgnoring($rating->user_id));
        });
    }

to

PHP: 
    protected function filterResults(\XF\Mvc\Entity\AbstractCollection $results)
    {
        $visitor = \XF::visitor();

        return $results->filter(function(Rating $rating) use($visitor)
        {
            return ($rating->canView() && !$visitor->isIgnoring($rating->user_id));
        });
    }
 
MEGAHERZ

MEGAHERZ

Collaborate
Collaborate
Registered
Joined
Mar 16, 2019
Messages
50
Points
38

Reputation:

BattleKing said:
try to change in file "src\addons\Brivium\AdvancedThreadRating\FindNew\RatingItem.php" the following function from
PHP: 
    protected function filterResults(\XF\Mvc\Entity\ArrayCollection $results)
    {
        $visitor = \XF::visitor();

        return $results->filter(function(Rating $rating) use($visitor)
        {
            return ($rating->canView() && !$visitor->isIgnoring($rating->user_id));
        });
    }

to

PHP: 
    protected function filterResults(\XF\Mvc\Entity\AbstractCollection $results)
    {
        $visitor = \XF::visitor();

        return $results->filter(function(Rating $rating) use($visitor)
        {
            return ($rating->canView() && !$visitor->isIgnoring($rating->user_id));
        });
    }
Click to expand...
BattleKingnow getting after changing to that code
image_2023-09-26_011806924.png

Code: 
Stack trace
#0 src/addons/Brivium/AdvancedThreadRating/Entity/Rating.php(171): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Att...', '/www/wwwroot/le...', 171)
#1 src/XF/Template/Templater.php(1192): Brivium\AdvancedThreadRating\Entity\Rating->canWarn()
#2 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(445): XF\Template\Templater->method(Object(Brivium\AdvancedThreadRating\Entity\Rating), 'canWarn', Array)
#3 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#4 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(293): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_public', Array, Array)
#5 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#6 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(249): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review', Array, Array)
#7 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#8 internal_data/code_cache/templates/l1/s50/public/BRATR_thread_reviews.php(38): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_list', Array, Array)
#9 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('BRATR_thread_re...', Array)
#11 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#12 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('Brivium\\Advance...', 'public:BRATR_th...', Array)
#13 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#16 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#17 src/XF.php(524): XF\App->run()
#18 index.php(20): XF::runApp('XF\\Pub\\App')
#19 {main}
Request state
array(4) {
  ["url"] => string(62) "/threads/thread name/br-reviews"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

&

Code: 
Stack trace
#0 src/addons/Brivium/AdvancedThreadRating/Entity/Rating.php(171): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Att...', '/www/wwwroot/le...', 171)
#1 src/XF/Template/Templater.php(1192): Brivium\AdvancedThreadRating\Entity\Rating->canWarn()
#2 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(445): XF\Template\Templater->method(Object(Brivium\AdvancedThreadRating\Entity\Rating), 'canWarn', Array)
#3 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#4 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(293): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_public', Array, Array)
#5 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#6 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(249): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review', Array, Array)
#7 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#8 internal_data/code_cache/templates/l1/s50/public/BRATR_thread_reviews.php(38): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_list', Array, Array)
#9 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('BRATR_thread_re...', Array)
#11 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#12 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('Brivium\\Advance...', 'public:BRATR_th...', Array)
#13 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#16 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#17 src/XF.php(524): XF\App->run()
#18 index.php(20): XF::runApp('XF\\Pub\\App')
#19 {main}
Request state
array(4) {
  ["url"] => string(62) "/threads/thread name/br-reviews"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
 
BattleKing

BattleKing

Spirit of darkness
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P Member
Collaborate
Registered
Joined
May 24, 2020
Messages
3,520
Points
523

Reputation:

MEGAHERZ said:
now getting after changing to that code
View attachment 37058
Code: 
Stack trace
#0 src/addons/Brivium/AdvancedThreadRating/Entity/Rating.php(171): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Att...', '/www/wwwroot/le...', 171)
#1 src/XF/Template/Templater.php(1192): Brivium\AdvancedThreadRating\Entity\Rating->canWarn()
#2 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(445): XF\Template\Templater->method(Object(Brivium\AdvancedThreadRating\Entity\Rating), 'canWarn', Array)
#3 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#4 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(293): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_public', Array, Array)
#5 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#6 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(249): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review', Array, Array)
#7 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#8 internal_data/code_cache/templates/l1/s50/public/BRATR_thread_reviews.php(38): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_list', Array, Array)
#9 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('BRATR_thread_re...', Array)
#11 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#12 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('Brivium\\Advance...', 'public:BRATR_th...', Array)
#13 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#16 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#17 src/XF.php(524): XF\App->run()
#18 index.php(20): XF::runApp('XF\\Pub\\App')
#19 {main}
Request state
array(4) {
  ["url"] => string(62) "/threads/thread name/br-reviews"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

&

Code: 
Stack trace
#0 src/addons/Brivium/AdvancedThreadRating/Entity/Rating.php(171): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Att...', '/www/wwwroot/le...', 171)
#1 src/XF/Template/Templater.php(1192): Brivium\AdvancedThreadRating\Entity\Rating->canWarn()
#2 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(445): XF\Template\Templater->method(Object(Brivium\AdvancedThreadRating\Entity\Rating), 'canWarn', Array)
#3 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#4 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(293): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_public', Array, Array)
#5 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#6 internal_data/code_cache/templates/l1/s50/public/BRATR_rating_macros.php(249): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review', Array, Array)
#7 src/XF/Template/Templater.php(825): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#8 internal_data/code_cache/templates/l1/s50/public/BRATR_thread_reviews.php(38): XF\Template\Templater->callMacro('BRATR_rating_ma...', 'review_list', Array, Array)
#9 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(XFA\RMMarketplace\XF\Template\Templater), Array, NULL)
#10 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('BRATR_thread_re...', Array)
#11 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#12 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('Brivium\\Advance...', 'public:BRATR_th...', Array)
#13 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#15 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#16 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#17 src/XF.php(524): XF\App->run()
#18 index.php(20): XF::runApp('XF\\Pub\\App')
#19 {main}
Request state
array(4) {
  ["url"] => string(62) "/threads/thread name/br-reviews"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
Click to expand...
MEGAHERZlooks like PHP 8 is used, I need to install the addon and check it
 
You must log in or register to reply here.
Top